Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update @types/react version #7655

Merged
merged 1 commit into from
Apr 10, 2022
Merged

chore: update @types/react version #7655

merged 1 commit into from
Apr 10, 2022

Conversation

li-jia-nan
Copy link
Contributor

@li-jia-nan li-jia-nan commented Apr 8, 2022 •
edited
Loading

Description

update @types/react&@types/react-dom version

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@li-jia-nan li-jia-nan closed this Apr 8, 2022
@li-jia-nan li-jia-nan reopened this Apr 8, 2022
@bluwy bluwy mentioned this pull request Apr 10, 2022
Closed
9 tasks
bluwy
bluwy approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to be working fine.

@bluwy bluwy requested a review from aleclarson April 10, 2022 13:35
@bluwy bluwy added p1-chore Doesn't change code behavior (priority) plugin: react labels Apr 10, 2022
@li-jia-nan li-jia-nan requested a review from bluwy April 10, 2022 13:54
@patak-dev patak-dev merged commit eb57627 into vitejs:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleclarson aleclarson Awaiting requested review from aleclarson

@bluwy bluwy Awaiting requested review from bluwy

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@li-jia-nan @bluwy @patak-dev