Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: vite dev default port is now 5173 #8148

Merged
merged 1 commit into from
May 12, 2022
Merged

feat!: vite dev default port is now 5173 #8148

merged 1 commit into from
May 12, 2022

Conversation

patak-dev
Copy link
Member

Description

Switch from 3000 to 5173 for the vite dev server port, avoiding a common port as Vite's default.

We already migrated from 5000 to 4173 for the preview server in a prev minor so they will be aligned now.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev changed the title feat: vite dev default port is now 5173 feat!: vite dev default port is now 5173 May 12, 2022
Shinigami92
Shinigami92 approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patak-dev patak-dev merged commit 1cc2e2d into main May 12, 2022
@patak-dev patak-dev deleted the feat/vite-port-riddle branch May 12, 2022 14:47
@antfu antfu added this to the 3.0 milestone May 13, 2022
sapphi-red added a commit to sapphi-red/vite that referenced this pull request May 31, 2022
@sapphi-red
docs: mention default port change from vitejs#8148
f1d8063
@benmccann benmccann mentioned this pull request Jul 7, 2022
Merged
5 tasks
@MarvinJWendt
Copy link

Was this intentionally choosen, because it looks kinda like VITE? 😄

5173
VITE

@zhengxiaoyao0716
Copy link

Port 5173 may be used by Hyper-V due to Windows mistakenly setting the reserved port range to 1025-15000.
Of course it's not the responsibility of vite, just a reminder to prevent others meting the problem.

Reference:
https://stackoverflow.com/questions/48478869/cannot-bind-to-some-ports-due-to-permission-denied/62359555#62359555
https://learn.microsoft.com/en-us/troubleshoot/windows-server/networking/default-dynamic-port-range-tcpip-chang#introduction
docker/for-win#3171 (comment)

@christhompsongoogle christhompsongoogle mentioned this pull request Dec 20, 2023
Merged
@benjaminpjones benjaminpjones mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@patak-dev @MarvinJWendt @zhengxiaoyao0716 @Shinigami92 @antfu