feat(create-vite): add type: module to all templates
#8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
reviewed
May 21, 2022
| @@ -2,6 +2,7 @@ | |||
| "name": "vite-lit-ts-starter", | |||
| "private": true, | |||
| "version": "0.0.0", | |||
| "type": "module", | |||
| "main": "dist/my-element.es.mjs", | |||
There was a problem hiding this comment.
Should we also use dist/my-element.js now that we type module? I think it is better if the templates already provide a clean world for ES, and add extra noise for CJS.
There was a problem hiding this comment.
Looks like we need to change this once we switch the templates to Vite 3, as this has been changed by #8107
patak-dev
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really change the functionality but is more like a move to help the community to start projects in ESM and help the overall migration.