refactor(plugin-legacy): improve default polyfill #8312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will dedupe imports and debug output. (does not affect output though)
sapphi-red
added
plugin: legacy
p2-nice-to-have
sapphi-red
commented
May 24, 2022
Comment on lines
+146
to
+152
| // check if the target needs Promise polyfill because SystemJS relies on it | ||
| // https://github.com/systemjs/systemjs#ie11-support | ||
| await detectPolyfills( | ||
| `Promise.resolve(); Promise.all();`, | ||
| targets, | ||
| legacyPolyfills | ||
| ) |
There was a problem hiding this comment.
Polyfills other than core-js/modules/es.promise may be added for Promise.resolve/Promise.all so the if condition is not correct.
| // check if the target needs Promise polyfill because SystemJS relies on it | ||
| // https://github.com/systemjs/systemjs#ie11-support | ||
| await detectPolyfills( | ||
| `Promise.resolve(); Promise.all();`, |
There was a problem hiding this comment.
Adding Promise.all() makes legacyPolyfills to include core-js/modules/es.array.iterator.js.
sapphi-red
changed the title
patak-dev
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following things.
[@vitejs/plugin-legacy] legacy polyfills:output (indirectly): polyfills-legacy.js throw error: Cannot assign to read only property 'prototype' of function #8287 (comment)I tested this with create-vite (vanilla-js) with IE 11.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).