feat: respect esbuild minify config #8754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6065
Additional context
Been thinking about the issue, and maybe it make sense to scope minify to certain aspects only.
Logic:
minify*
options are specified, use them instead ofminify: true
(which overrides all the specific options totrue
)minify: true
minifyWhitespace
is false for es library build.Other improvements
minifySyntax
andminifyIdentifiers
as those are safe.build.minify: false
, regardless ofesbuild.minify
andesbuild.minify*
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).