Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class not passed when component has a comment (production build) #885

Closed
guillenotfound opened this issue Oct 6, 2020 · 2 comments
Closed

Comments

@guillenotfound
Copy link
Contributor

Describe the bug

Classes not passed down components from vue-router when component has a comment, only happens on production build.

Reproduction

Here's a demo repository with the issue, if you run vite it will work, but if you build and use a server like caddy --root dist --listen :3001 you'll notice that no class are injected when rendering home or sidebar components.

https://github.com/guillenotfound/sample-router-class-error

Second.vue is the only component without a comment inside the template, during development all classes defined for router-link are passed down to the components but those classes are missing when building for production as shown in the image below:

image

System Info

  • required vite version: rc4
  • required Operating System: mac os x
  • required Node version: 12.18.4
@underfin
Copy link
Member

underfin commented Oct 9, 2020

It is already fixed by #732

@underfin underfin closed this as completed Oct 9, 2020
@guillenotfound
Copy link
Contributor Author

Nice! Is there any ETA for a new release?

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants