-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ssrBuild flag in config env #8863
Conversation
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Alternative for the API, export default defineConfig(({ command, mode, build: { ssr }}) => {
// ...
} The issue that I see is that people without TS may be confused by using So I prefer we keep the current |
Modified the PR so |
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
There seems to be little usage for this feature. We opened a discussion to check if we should stabilize or deprecate it in Vite 5: Are you currently using this feature @Kingdutch? |
Fixes #8835
Description
Adds a flag to apply conditional configuration depending on SSR build. This doesn't apply for SSR dev, as the config is shared for it.
Should we pass the value of
config.build.ssr
instead, so the user can also config depending on the SSR entry?Edit: Blu said yes, it is now implemented as
string | boolean
👍🏼What is the purpose of this pull request?