fix: ssrLoadModule executes code in non-strict mode, fixes #9197 #9199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vite-ecosystem-ci run for this PR: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2692996595 |
patak-dev
added
p3-minor-bug
patak-dev
changed the title
7 tasks
danielroe
approved these changes
Jul 19, 2022
bluwy
reviewed
Jul 19, 2022
bluwy
approved these changes
Jul 19, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context:
Doing the PR with @Rich-Harris suggested change so we can run vite-ecosystem-ci to see if we can include this in the next patch. @brillout would you also review this one to check vite-plugin-ssr will be happy after this change?
What is the purpose of this pull request?