fix(hmr): duplicated modules because of query params mismatch (fixes #2255) #9773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2255 by only appending
?import
when it should be.I passed
explicitImportRequired
property to do the check on server side, not to duplicateisExplicitImportRequired
function toclient/client.ts
.fixes #2255
Additional context
?import
is used to differentiateimport './foo.png'
andfetch('./foo.png')
. The ideal way is to useAccept
header but unfortunately requests byimport
usesAccept: */*
and cannot be used.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).