fix(build): build project path error

[btea]

Description

fix #9771

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[patak-dev]

We shouldn't have a particular case for index.html. This will be still broken for foo.html. We need to check where input is being used which results in the paths being different on both platforms. Probably in the html plugin, when computing these paths. I think we may be missing a normalizePath. https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/html.ts#L929

[btea]

ok, thanks for the explanation

[patak-dev]

Thanks for the fix @btea! Would you try to add a test case so we avoid regressions in the future here? I think you should be able to add index.html in the config of the assets playground to replicate the issue?

[btea]

@patak-dev Hello, Could you help me add the test case? I don't know how to add it. Thanks!

[bluwy]

Whoops I didn't see the comment before approving 😅 @btea it should be setting the input like https://github.com/JiPaix/Fukayo/blob/183069a81a17b9b651261d374a253641edf59a73/packages/renderer/vite.config.js#L50 in the assets playground, which should be all that's need I think.

[btea]

@bluwy Hi, did I misunderstand what you meant? After I updated the code, the ci failed 😅

[patak-dev]

Oh, sorry @btea, looks like index.html works if you run the repo directly, but not in our tests since root ends up being CWD. Setting the root for all tests may be a good idea moving forward, but better to work on this in another PR. Let's revert the tests change.
@JiPaix, would you confirm that this PR fixes the issue for you?

[JiPaix]

Oh, sorry @btea, looks like index.html works if you run the repo directly, but not in our tests since root ends up being CWD. Setting the root for all tests may be a good idea moving forward, but better to work on this in another PR. Let's revert the tests change. @JiPaix, would you confirm that this PR fixes the issue for you?

@patak-dev

rollupOptions.input: 'index.html'.

• linux: ./src/filename.ext
• windows: ./filename.ext

same output with base: '' and base: './'.

[patak-dev]

Thanks for testing @JiPaix, let see if @btea is able to reproduce it 👍🏼

[btea]

@patak-dev @JiPaix I tested it with wsl, the output is normal, the path does not contain src.

[patak-dev]

@sapphi-red maybe you could try this one with a real Windows box there?

[sapphi-red]

It's working for me.
I tested with create-vite vanilla with the following config.

export default {
  base: './',
  build: {
    rollupOptions: {
      input: 'index.html'
    }
  }
}

Build result (index.html) with both Windows and WSL:

    <script type="module" crossorigin src="./assets/index.0771aa93.js"></script>
    <link rel="stylesheet" href="./assets/index.d0964974.css">

[patak-dev]

@JiPaix would you provide a minimal reproduction of your issue with this PR?

[JiPaix]

@sapphi-red @patak-dev @btea

Nvm it works, i was doing something wrong...
sorry to waste your time 🤕