Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): enable inlineDynamicImports when input has length 1 #9904

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(ssr): enable inlineDynamicImports when input has length 1 #9904

merged 1 commit into from
Aug 30, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Aug 30, 2022

Description

This enables inlineDynamicImports when input has length 1 which is same as input string.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9ac5075 into vitejs:main Aug 30, 2022
@ydcjeff ydcjeff deleted the idi-legnth-1 branch August 31, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants