Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to unbox lists #64

Closed
keller-mark opened this issue May 25, 2022 · 0 comments · Fixed by #63
Closed

Don't try to unbox lists #64

keller-mark opened this issue May 25, 2022 · 0 comments · Fixed by #63
Labels
bug Something isn't working

Comments

@keller-mark
Copy link
Member

Describe the bug

In https://github.com/vitessce/vitessceR/blob/main/R/config.R#L210, we only should be unboxing scalar values, not lists/vectors.

To Reproduce

Try to set cellSetColor coordination value,

vc$link_views(
c(scatterplot_pca, scatterplot_tsne),
c(CoordinationType$CELL_SET_COLOR),
c_values = list(list(obj_list(path = c("Cell Type Annotations", "Astrocyte", "Astrocyte Gfap"),
color = as.vector(col2rgb("blue")))))
)
in json_remote.Rmd vignette

Throws Error: only atomic vectors of length 1 or data frames with 1 row can be unboxed.

Expected behavior
No error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant