Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled error in VTOrc recoverDeadPrimary #12509

Closed
frouioui opened this issue Feb 28, 2023 · 0 comments · Fixed by #12510, #12511 or #12399
Closed

Unhandled error in VTOrc recoverDeadPrimary #12509

frouioui opened this issue Feb 28, 2023 · 0 comments · Fixed by #12510, #12511 or #12399
Assignees
@frouioui
Labels
Component: VTorc Vitess Orchestrator integration Type: Bug

Comments

@frouioui
Copy link
Member

Overview of the Issue

The error returned by inst.ReadTablet(analysisEntry.AnalyzedInstanceKey) in VTOrc's recoverDeadPrimary is not handled. This can lead to panics.

vitess/go/vt/vtorc/logic/topology_recovery.go

Line 257 in 607a9a4

tablet, err := inst.ReadTablet(analysisEntry.AnalyzedInstanceKey)

Reproduction Steps

n/a

Binary Version

main, release-16.0, release-15.0

Operating System and Environment details

n/a

Log Fragments

No response
@frouioui frouioui added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged Component: VTorc Vitess Orchestrator integration and removed Needs Triage This issue needs to be correctly labelled and triaged labels Feb 28, 2023
@frouioui frouioui self-assigned this Feb 28, 2023
This was referenced Feb 28, 2023
Merged
Merged
Merged
This was linked to pull requests Feb 28, 2023
Fix unhandled error in VTOrc recoverDeadPrimary #12510
Merged
Fix unhandled error in VTOrc recoverDeadPrimary #12511
Merged
Upgrade to go1.20.1 #12399
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouioui frouioui

Labels
Component: VTorc Vitess Orchestrator integration Type: Bug
Projects
None yet
Milestone
No milestone
1 participant
@frouioui