Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Backup/Restore metrics deleted in v16 #13336

Closed
deepthi opened this issue Jun 16, 2023 · 1 comment
Closed

Bug Report: Backup/Restore metrics deleted in v16 #13336

deepthi opened this issue Jun 16, 2023 · 1 comment

Comments

@deepthi
Copy link
Member

deepthi commented Jun 16, 2023

Overview of the Issue

In #11520, we removed the local_metadata table from the sidecar db. Along with metadata used for orchestrator integration, this table also used to store 2 additional pieces of information:

	// Add backupTime and restorePosition to LocalMetadata
	params.LocalMetadata["RestoredBackupTime"] = manifest.BackupTime
	params.LocalMetadata["RestorePosition"] = mysql.EncodePosition(manifest.Position)

This information is no longer available on a restored vttablet.

Reproduction Steps

On a running vitess cluster (local example will suffice):

  • take a backup of a keyspace/shard
  • restore one of the tablets from backup (or create a new tablet from backup)
  • there's no way to know what time or position the tablet was restored from

Binary Version

main, v17, v16

Operating System and Environment details

any

Log Fragments

No response

@deepthi deepthi added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged Type: Regression Component: Backup and Restore and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jun 16, 2023
@deepthi deepthi self-assigned this Jun 16, 2023
@frouioui
Copy link
Member

@deepthi @rohit-nayak-ps can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants