Bug Report: CI does not fail when an e2e race test fails

[brendar]

Overview of the Issue

There is a bug in tools/e2e_test_race.sh that causes it to exit 0 even when a data race is detected or a test fails.

For example, this End-to-End Test (Race) job from a recent PR has 3 failures with race detected during execution of test but ultimately reports success: https://github.com/vitessio/vitess/actions/runs/5653523125/job/15314840298

The cause is this line in tools/e2e_test_race.sh:

vitess/tools/e2e_test_race.sh

Lines 42 to 43 in b131336

	echo "$all_e2e_tests" | xargs go test $VT_GO_PARALLEL -race 2>&1 | tee $temp_log_file
	if [ ${PIPESTATUS[0]} -ne 0 ]; then

Which should be: ${PIPESTATUS[1]}

I didn't open a PR to fix that since the PR will fail CI until all the races are fixed, but I confirmed the issue with a draft PR here: Shopify#112

Reproduction Steps

n/a

Binary Version

n/a

Operating System and Environment details

n/a

Log Fragments

n/a