Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golang/protobuf dependency #15425

Closed
deepthi opened this issue Mar 8, 2024 · 2 comments · Fixed by #15426
Closed

Upgrade golang/protobuf dependency #15425

deepthi opened this issue Mar 8, 2024 · 2 comments · Fixed by #15426
Assignees
@frouioui
Labels
Release Blocker: release-18.0 This item blocks the release on branch release-18.0 Release Blocker: release-19.0 This item blocks the release on branch release-19.0 Type: CI/Build
Milestone
v19.0.1

Comments

@deepthi
Copy link
Member

deepthi commented Mar 8, 2024 •
edited by frouioui
Loading

Task

When we upgraded to go1.22.1, we bumped the google protobuf dependency. However, as just announced by the golang team

version 1.33.0 of google.golang.org/protobuf inadvertently introduced an incompatibility with the older github.com/golang/protobuf module. (golang/protobuf#1596) Users of the older module should update to github.com/golang/protobuf@v1.5.4.

So we should bump the golang protobuf dependency as well.

Affected Release(s)

v19.0.1, v18.0.3
@deepthi deepthi added Type: CI/Build Needs Triage This issue needs to be correctly labelled and triaged and removed Needs Triage This issue needs to be correctly labelled and triaged labels Mar 8, 2024
@deepthi deepthi added this to the v19.0.1 milestone Mar 8, 2024
@deepthi
Copy link
Member Author

deepthi commented Mar 8, 2024

This also needs to be done on release-19.0 before v19.0.1

@frouioui frouioui self-assigned this Mar 8, 2024
@frouioui
Copy link
Member

frouioui commented Mar 8, 2024 •
edited
Loading

backporting to v18.0.3 as we are using v1.33.0 on release-18.0.

@frouioui frouioui mentioned this issue Mar 8, 2024
Merged
5 tasks
@frouioui frouioui added Release Blocker: release-19.0 This item blocks the release on branch release-19.0 Release Blocker: release-18.0 This item blocks the release on branch release-18.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouioui frouioui

Labels
Release Blocker: release-18.0 This item blocks the release on branch release-18.0 Release Blocker: release-19.0 This item blocks the release on branch release-19.0 Type: CI/Build
Projects
None yet
Milestone
v19.0.1
Development

Successfully merging a pull request may close this issue.

bump github.com/golang/protobuf to v1.5.4 planetscale/vitess
2 participants
@deepthi @frouioui