Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: MySQL Shell backup engine doesn't release global read lock when backup fails #17011

Closed
rvrangel opened this issue Oct 18, 2024 · 0 comments · Fixed by #17000
Closed

Comments

@rvrangel
Copy link
Contributor

Overview of the Issue

As we roll out the new mysqlshell backup engine, we noticed that when a backup fails (usually at the beginning) because of creds/wrong args/issues with the binary/etc, then the global read lock will not be released.

This means replication will be blocked on the tablet and also new attempts to take a new backup will fail because the lock already exists. We need to ensure that when completing the execution of ExecuteBackup() for the engine, the lock will always be released, no matter if the backup is successful or not.

Reproduction Steps

  1. change --mysql-shell-flags to something invalid
  2. take a backup, which will fail
  3. global lock will still be held after the backup
  4. a new backup attempt will fail trying to acquire a global read lock since it already exists

Binary Version

happens on v21 after #16295 was merged

Operating System and Environment details

N/A

Log Fragments

No response

@rvrangel rvrangel added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged labels Oct 18, 2024
@frouioui frouioui added Component: Backup and Restore and removed Needs Triage This issue needs to be correctly labelled and triaged labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants