Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PROXY protocol (v1/v2) #5554

Closed
aquarapid opened this issue Dec 12, 2019 · 1 comment
Closed

Support PROXY protocol (v1/v2) #5554

aquarapid opened this issue Dec 12, 2019 · 1 comment
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@aquarapid
Copy link
Contributor

Haproxy pioneered a protocol to communicate client connection details (source IP/port) from the SLB layer to the service behind the SLB. It would be great if vtgate could support this, and thus log the actual client connection details, since vtgate is typically deployed behind an SLB.

There is a go module out there that implements this: https://github.com/pires/go-proxyproto

Page about the protocol (high level, including existing software that supports it): https://www.haproxy.com/blog/haproxy/proxy-protocol/

Spec here: https://www.haproxy.org/download/2.0/doc/proxy-protocol.txt

@morgo morgo added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Dec 12, 2019
@aquarapid
Copy link
Contributor Author

Fixed by #5563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

No branches or pull requests

2 participants