Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Store blacklisted tables in vttablet instead of topo #5660

Open
deepthi opened this issue Jan 6, 2020 · 2 comments
Open

RFC: Store blacklisted tables in vttablet instead of topo #5660

deepthi opened this issue Jan 6, 2020 · 2 comments

Comments

@deepthi
Copy link
Member

deepthi commented Jan 6, 2020

Requirement

As part of #4790, we have the following requirement:

For example, while migrating masters (or writes), we have to first force readonly on the source. This is currently achieved by pushing tablet control records or blacklisted tables into the topo. Instead, we’ll reimplement this by directly writing this metadata into the relevant vttablets where the action will be taken.

Proposed Design

  • Add a table in _vt schema to hold the list of blacklisted tables. We will store a proto representation of the string array that represents this list.
  • Add a new vttablet RPC UpdateBlacklistedTables
  • Replace calls to ShardInfo.UpdateSourceBlacklistedTables with calls to TabletManagerClient.UpdateBlacklistedTables
  • For now, we will leave the fields in topo, and deprecate them in a future release
@deepthi
Copy link
Member Author

deepthi commented Jan 6, 2020

cc @sougou @rafael

@morgo morgo added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Jan 7, 2020
@saifalharthi saifalharthi removed their assignment Feb 24, 2020
@deepthi
Copy link
Member Author

deepthi commented Jul 18, 2020

EDIT: When we get to this, we also need to replace blacklist with blocklist (or something similar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants