sqlparser errors on auto_increment not null but handles not null auto_increment

[jmhodges]

The order of auto_increment not null vs not null auto_increment in create table statements doesn't matter to mysql, but sqlparser returns an error in the first case.

That is, this statement errors out when parsed:

create table blocked_domains (id bigint auto_increment not null, primary key (id));

while this one parses fine:

create table blocked_domains (id bigint not null auto_increment, primary key (id));

Sample code:

package main

import (
	"fmt"

	"github.com/vitessio/vitess/go/vt/sqlparser"
)

func main() {
	notNullLast := "create table blocked_domains (id bigint auto_increment not null, primary key (id));"
	if err := parse(notNullLast); err != nil {
		fmt.Printf("notNullLast errored: %s\n", err)
	} else {
		fmt.Println("notNullLast worked")
	}
	notNullFirst := "create table blocked_domains (id bigint not null auto_increment, primary key (id));"
	if err := parse(notNullFirst); err != nil {
		fmt.Printf("notNullFirst errored: %s\n", err)
	} else {
		fmt.Println("notNullFirst worked")
	}
}

func parse(contents string) error {
	t := sqlparser.NewStringTokenizer(contents)
	_, err := sqlparser.ParseNextStrictDDL(t)
	return err
}

That will produce

notNullLast errored: syntax error at position 59 near 'not'
notNullFirst worked

and we'd like to not see that first error.

[saifalharthi]

This seems to be fixed, I tested it on master.
For the first ordering

mysql> create table blocked_domains (id bigint auto_increment not null, primary key (id));
Query OK, 0 rows affected (0.03 sec)

For the second ordering

mysql> create table blocked_domains (id bigint not null auto_increment, primary key (id));
Query OK, 0 rows affected (0.03 sec)

I think we can close this issue.

[systay]

Please re-open if it's not really fixed.