Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql like select * from t where name like '*//*' in StripComments will lead to a deadloop and a cpu usage raise #5981

Closed
xhh1989 opened this issue Mar 27, 2020 · 0 comments · Fixed by #5984
Closed

sql like select * from t where name like '*//*' in StripComments will lead to a deadloop and a cpu usage raise #5981

xhh1989 opened this issue Mar 27, 2020 · 0 comments · Fixed by #5984

Comments

@xhh1989
Copy link
Contributor

xhh1989 commented Mar 27, 2020 •
edited by deepthi
Loading

vitess/go/vt/sqlparser/comments.go

Line 169 in 490bac1

func StripComments(sql string) string {

sql like select * from t where name like '*//*' in StripComments will lead to a deadloop and a cpu usge raise
@harshit-gangal harshit-gangal mentioned this issue Mar 28, 2020
Merged
@deepthi deepthi changed the title sql like select * from t wehre name like '*//*' in StripComments will lead to a deadloop and a cpu usge raise sql like select * from t where name like '*//*' in StripComments will lead to a deadloop and a cpu usge raise Mar 31, 2020
@deepthi deepthi changed the title sql like select * from t where name like '*//*' in StripComments will lead to a deadloop and a cpu usge raise sql like select * from t where name like '*//*' in StripComments will lead to a deadloop and a cpu usage raise Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Vtexplains StripComments planetscale/vitess
1 participant
@xhh1989