Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitess Heartbeats: Additional metrics/stats #6528

Closed
gedgar opened this issue Aug 3, 2020 · 2 comments · Fixed by #6634
Closed

Vitess Heartbeats: Additional metrics/stats #6528

gedgar opened this issue Aug 3, 2020 · 2 comments · Fixed by #6634
Assignees
Milestone

Comments

@gedgar
Copy link
Contributor

gedgar commented Aug 3, 2020

Feature Description

It would be great if we had more visibility/metrics around Vitess heartbeat stats. At a lower polling frequencies (eg once per minute), HeartbeatCurrentLagNs only provides a glimpse into the current replication lag at a specific poll point.

It would be awesome if we had histograms similar to the query timing.

Additionally, it would also be useful if we exposed a counter showing the number of times replication lag exceeded a specific (configurable?) threshold over the last minute, etc.

@deepthi deepthi self-assigned this Aug 24, 2020
@deepthi
Copy link
Member

deepthi commented Aug 26, 2020

Additionally, it would also be useful if we exposed a counter showing the number of times replication lag exceeded a specific (configurable?) threshold over the last minute, etc.

We should not be doing this in vitess, it should be done using Prometheus or something similar.
In general we only export point-in-time values and cumulative values, not historical computations over defined time periods.

@derekperkins
Copy link
Member

derekperkins commented Aug 26, 2020

If we move forward with #6476 to have vtctld use MySQL under the hood, we'd be able to store basic time series and power future dashboards without having to introduce Prometheus or another database component

@askdba askdba added this to the v8.0 milestone Oct 6, 2020
@aquarapid aquarapid modified the milestone: v8.0 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants