Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: TabletTypeCount is not incremented during tablet startup #7389

Closed
deepthi opened this issue Jan 27, 2021 · 1 comment · Fixed by #7390
Closed

Regression: TabletTypeCount is not incremented during tablet startup #7389

deepthi opened this issue Jan 27, 2021 · 1 comment · Fixed by #7390
Assignees
@deepthi

Comments

@deepthi
Copy link
Member

deepthi commented Jan 27, 2021

Overview of the Issue

We need to add 1 to statsTabletTypeCount in exportStats

vitess/go/vt/vttablet/tabletmanager/tm_init.go

Line 635 in 72b75d2

func (tm *TabletManager) exportStats() {

Reproduction Steps

Look at /debug/vars on any vttablet after bringing up a vitess cluster. TabletTypeCount will be 0, it should be 1.
@deepthi
Copy link
Member Author

deepthi commented Jan 27, 2021

This is only an off by 1 error, so no need to backport.

@deepthi deepthi mentioned this issue Jan 27, 2021
Merged
8 tasks
@deepthi deepthi self-assigned this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthi deepthi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly initialize statsTabletTypeCounts during startup planetscale/vitess
1 participant
@deepthi