Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add errcheck to CI build #8222

Closed
ajm188 opened this issue May 31, 2021 · 0 comments · Fixed by #7996
Closed

Add errcheck to CI build #8222

ajm188 opened this issue May 31, 2021 · 0 comments · Fixed by #7996
Assignees
@ajm188
Labels
Component: Build/CI Type: Feature Request

Comments

@ajm188
Copy link
Contributor

ajm188 commented May 31, 2021

Feature Description

As discussed in this PR, we want to start enabling errcheck linter in CI to progressively enforce being explicit about error values, especially in places where we're currently ignoring them (it was pointed out that ignoring errors has made debugging tests particularly painful).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajm188 ajm188

Labels
Component: Build/CI Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci] Add errcheck to golangci-lint tinyspeck/vitess
1 participant
@ajm188