Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing to VtctldServer endpoints #8265

Closed
ajm188 opened this issue Jun 5, 2021 · 0 comments · Fixed by #8285
Closed

Add tracing to VtctldServer endpoints #8265

ajm188 opened this issue Jun 5, 2021 · 0 comments · Fixed by #8285
Assignees
@ajm188
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@ajm188
Copy link
Contributor

ajm188 commented Jun 5, 2021

Feature Description

None of the new VtctldServer rpcs create any tracing spans (to be fair, neither did the old ones). We should add those for users that want additional observability.
@ajm188 ajm188 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management labels Jun 5, 2021
@ajm188 ajm188 self-assigned this Jun 5, 2021
@ajm188 ajm188 mentioned this issue Jun 5, 2021
Merged
2 tasks
@ajm188 ajm188 mentioned this issue Jun 8, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajm188 ajm188

Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vtctldserver] Add tracing tinyspeck/vitess
1 participant
@ajm188