Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional to enable logging in tracing plugins #8288

Closed
ajm188 opened this issue Jun 8, 2021 · 0 comments · Fixed by #8289
Closed

Add optional to enable logging in tracing plugins #8288

ajm188 opened this issue Jun 8, 2021 · 0 comments · Fixed by #8289
Assignees
@ajm188
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@ajm188
Copy link
Contributor

ajm188 commented Jun 8, 2021

Feature Description

Both datadog and jaeger tracer implementations support some form of logger interface that can be passed to the tracer implementation for additional insight into what's happening in that part of the stack.

We should add a flag to package trace to allow users to toggle this on.

Use Case(s)

  • Debugging tracing issues.
@ajm188 ajm188 added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Jun 8, 2021
@ajm188 ajm188 self-assigned this Jun 8, 2021
@ajm188 ajm188 added the Component: Observability Pull requests that touch tracing/metrics/monitoring label Jun 8, 2021
@ajm188 ajm188 mentioned this issue Jun 8, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajm188 ajm188

Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[trace] Add logging support to opentracing plugins tinyspeck/vitess
1 participant
@ajm188