Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topo: update k8stopo CRD to use apiextensions.k8s.io/v1 #9044

Closed
derekperkins opened this issue Oct 20, 2021 · 3 comments
Closed

topo: update k8stopo CRD to use apiextensions.k8s.io/v1 #9044

derekperkins opened this issue Oct 20, 2021 · 3 comments
Milestone

Comments

@derekperkins
Copy link
Member

apiextensions.k8s.io/v1beta1 has been deprecated since k8s 1.16, and is removed in 1.22 that is already out. There should be minimal changes required other than changing the CRD apiVersion. Since we're 4 months away from the next release, I think this should get into v12
https://github.com/vitessio/vitess/tree/main/go/vt/topo/k8stopo

cc @carsonoid

@derekperkins derekperkins added this to the v12.0 milestone Oct 20, 2021
@derekperkins
Copy link
Member Author

I guess what I don't know is what the upgrade path looks like for users, if there are any

@carsonoid
Copy link
Contributor

carsonoid commented Oct 21, 2021

#9045 does the migration. Luckily there is no upgrade or change required for users. The CRD version just changes how the resource gets made. So switching to a new yaml and api for CRD creation won't change anything for any active users.

The only real change is that the new CRD yaml won't work if applied to clusters that don't have the apiextensions/v1 API enabled.

So the new yaml won't work for pre v1.16 k8s clusters. But technically the topo still can if someone were to manually mess with the spec and create the same CRD using the old API.

@derekperkins
Copy link
Member Author

Fixed by #9045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants