fix: vitest/expect-expect throws false positive (#604)

* fix: expect-expect throws false positive * test: add test * test: add test in no-disabled-tests
vitest-dev · Dec 19, 2024 · 7fd75ea · 7fd75ea
1 parent 085e320
commit 7fd75ea
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/src/utils/parse-vitest-fn-call.ts b/src/utils/parse-vitest-fn-call.ts
@@ -362,6 +362,11 @@ const resolvePossibleAliasedGlobal = (
   return null
 }
 
+const isAncestorTestCaseCall = ({ parent }: TSESTree.Node) => {
+  if (parent?.type === AST_NODE_TYPES.CallExpression && parent.callee.type === AST_NODE_TYPES.Identifier)
+    return TestCaseName.hasOwnProperty(parent.callee.name)
+}
+
 export const resolveScope = (
   scope: TSESLint.Scope.Scope,
   identifier: string
@@ -383,7 +388,7 @@ export const resolveScope = (
       }
 
       const namedParam = isFunction(def.node) ? def.node.params.find(params => params.type === AST_NODE_TYPES.Identifier) : undefined
-      if (namedParam)
+      if (namedParam && isAncestorTestCaseCall(namedParam.parent))
         return 'testContext'
 
       const importDetails = describePossibleImportDef(def)

diff --git a/tests/expect-expect.test.ts b/tests/expect-expect.test.ts
@@ -36,7 +36,13 @@ const it = base.extend<{
  async bar({}, use) {
    await use('bar')
  }
-})`
+})`,
+    `
+it('example', async () => {
+  const result = Promise.reject<string>('error');
+
+  await expect(result.then((it) => it.toUpperCase())).rejects.toThrow();
+});`
   ],
   invalid: [
     {

diff --git a/tests/no-disabled-tests.test.ts b/tests/no-disabled-tests.test.ts
@@ -29,7 +29,16 @@ ruleTester.run(RULE_NAME, rule, {
     })`,
     `   import { test } from './test-utils';
 
-    test('something');`
+    test('something');`,
+    `test("foo", () => {
+      const upper1 = (x: string) => x.toUpperCase();
+      const upper2 = (y: string) => y.toUpperCase();
+      const upper3 = (xy: string) => xy.toUpperCase();
+      const upper4 = (yx: string) => yx.toUpperCase();
+      const upper5 = (a: string) => a.toUpperCase();
+      const length = (x: string) => x.length;
+      expect("test").toBe('test');
+    });`
   ],
   invalid: [
     {