fix: improve "isInternaRequest" check (#2541)

vitest-dev · Dec 20, 2022 · 2bb9a39 · 2bb9a39
1 parent 44581e2
commit 2bb9a39
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 29 deletions.
diff --git a/packages/vite-node/src/client.ts b/packages/vite-node/src/client.ts
@@ -13,35 +13,38 @@ import { extractSourceMap } from './source-map'
 const debugExecute = createDebug('vite-node:client:execute')
 const debugNative = createDebug('vite-node:client:native')
 
-export const DEFAULT_REQUEST_STUBS = {
-  '/@vite/client': {
-    injectQuery: (id: string) => id,
-    createHotContext() {
-      return {
-        accept: () => {},
-        prune: () => {},
-        dispose: () => {},
-        decline: () => {},
-        invalidate: () => {},
-        on: () => {},
-      }
-    },
-    updateStyle(id: string, css: string) {
-      if (typeof document === 'undefined')
-        return
-
-      const element = document.getElementById(id)
-      if (element)
-        element.remove()
-
-      const head = document.querySelector('head')
-      const style = document.createElement('style')
-      style.setAttribute('type', 'text/css')
-      style.id = id
-      style.innerHTML = css
-      head?.appendChild(style)
-    },
+const clientStub = {
+  injectQuery: (id: string) => id,
+  createHotContext() {
+    return {
+      accept: () => {},
+      prune: () => {},
+      dispose: () => {},
+      decline: () => {},
+      invalidate: () => {},
+      on: () => {},
+    }
   },
+  updateStyle(id: string, css: string) {
+    if (typeof document === 'undefined')
+      return
+
+    const element = document.getElementById(id)
+    if (element)
+      element.remove()
+
+    const head = document.querySelector('head')
+    const style = document.createElement('style')
+    style.setAttribute('type', 'text/css')
+    style.id = id
+    style.innerHTML = css
+    head?.appendChild(style)
+  },
+}
+
+export const DEFAULT_REQUEST_STUBS = {
+  '/@vite/client': clientStub,
+  '@vite/client': clientStub,
 }
 
 export class ModuleCacheMap extends Map<string, ModuleCache> {

diff --git a/packages/vite-node/src/utils.ts b/packages/vite-node/src/utils.ts
@@ -41,8 +41,15 @@ export const hashRE = /#.*$/s
 export const cleanUrl = (url: string): string =>
   url.replace(hashRE, '').replace(queryRE, '')
 
+const internalRequests = [
+  '@vite/client',
+  '@vite/env',
+]
+
+const internalRequestRegexp = new RegExp(`^/?(${internalRequests.join('|')})$`)
+
 export const isInternalRequest = (id: string): boolean => {
-  return id.startsWith('/@vite/')
+  return internalRequestRegexp.test(id)
 }
 
 export function normalizeModuleId(id: string) {

diff --git a/test/core/test/imports.test.ts b/test/core/test/imports.test.ts
@@ -61,3 +61,9 @@ test('dynamic import throws an error', async () => {
   // @ts-expect-error path does not exist
   await expect(() => import('./some-unknown-path')).rejects.toThrowError(/Failed to load/)
 })
+
+test('can import @vite/client', async () => {
+  const name = '@vite/client'
+  await expect(import(name)).resolves.not.toThrow()
+  await expect(import(`/${name}`)).resolves.not.toThrow()
+})