Skip to content

Commit ee72518

Browse files
authored
fix(browser): dedupe @vitest/browser/client (#6081)
1 parent 756ac2b commit ee72518

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

packages/browser/src/client/orchestrator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ async function getContainer(config: ResolvedConfig): Promise<HTMLDivElement> {
245245
return document.querySelector('#vitest-tester') as HTMLDivElement
246246
}
247247

248-
client.ws.addEventListener('open', async () => {
248+
client.waitForConnection().then(async () => {
249249
const testFiles = getBrowserState().files
250250

251251
await orchestrator.init()

packages/browser/src/client/public/error-catcher.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { channel, client } from '/@id/@vitest/browser/client'
1+
import { channel, client } from '@vitest/browser/client'
22

33
function on(event, listener) {
44
window.addEventListener(event, listener)

packages/browser/src/node/plugin.ts

+2
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,8 @@ export default (browserServer: BrowserServer, base = '/'): Plugin[] => {
166166
'vitest/utils',
167167
'vitest/browser',
168168
'vitest/runners',
169+
'@vitest/browser',
170+
'@vitest/browser/client',
169171
'@vitest/utils',
170172
'@vitest/utils/source-map',
171173
'@vitest/runner',

packages/browser/src/node/server.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class BrowserServer implements IBrowserServer {
2828
public testerHtml: Promise<string> | string
2929
public orchestratorHtml: Promise<string> | string
3030
public injectorJs: Promise<string> | string
31-
public errorCatcherJs: Promise<string> | string
31+
public errorCatcherPath: Promise<string> | string
3232
public stateJs: Promise<string> | string
3333

3434
public state: BrowserServerState
@@ -87,10 +87,7 @@ export class BrowserServer implements IBrowserServer {
8787
resolve(distRoot, 'client/esm-client-injector.js'),
8888
'utf8',
8989
).then(js => (this.injectorJs = js))
90-
this.errorCatcherJs = readFile(
91-
resolve(distRoot, 'client/error-catcher.js'),
92-
'utf8',
93-
).then(js => (this.errorCatcherJs = js))
90+
this.errorCatcherPath = resolve(distRoot, 'client/error-catcher.js')
9491
this.stateJs = readFile(
9592
resolve(distRoot, 'state.js'),
9693
'utf-8',

packages/browser/src/node/serverOrchestrator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export async function resolveOrchestrator(
7373
__VITEST_TITLE__: 'Vitest Browser Runner',
7474
__VITEST_SCRIPTS__: server.orchestratorScripts,
7575
__VITEST_INJECTOR__: `<script type="module">${injector}</script>`,
76-
__VITEST_ERROR_CATCHER__: `<script type="module">${server.errorCatcherJs}</script>`,
76+
__VITEST_ERROR_CATCHER__: `<script type="module" src="${server.errorCatcherPath}"></script>`,
7777
__VITEST_CONTEXT_ID__: JSON.stringify(contextId),
7878
})
7979
}

packages/browser/src/node/serverTester.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export async function resolveTester(
7474
__VITEST_TITLE__: 'Vitest Browser Tester',
7575
__VITEST_SCRIPTS__: server.testerScripts,
7676
__VITEST_INJECTOR__: `<script type="module">${injector}</script>`,
77-
__VITEST_ERROR_CATCHER__: `<script type="module">${server.errorCatcherJs}</script>`,
77+
__VITEST_ERROR_CATCHER__: `<script type="module" src="${server.errorCatcherPath}"></script>`,
7878
__VITEST_APPEND__:
7979
`<script type="module">
8080
__vitest_browser_runner__.runningFiles = ${tests}

0 commit comments

Comments
 (0)