Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Types: Argument of type 'UserProjectConfigExport' is not assignable to parameter of type 'UserWorkspaceConfig | Promise<UserWorkspaceConfig>' #3759

Closed
6 tasks done
jviall opened this issue Jul 11, 2023 · 5 comments

Comments

@jviall
Copy link

jviall commented Jul 11, 2023

Describe the bug

I've been using a workspace setup, following the docs to create a workspace at the root, and a shared base config that my individual projects can import and merge with any overrides. However, since upgrading my vitest/vite versions, the types are broken.

Argument of type 'UserProjectConfigExport' is not assignable to parameter of type 'UserWorkspaceConfig | Promise<UserWorkspaceConfig>'

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-uk4kgh?file=vite.config.ts

System Info

System:
    OS: macOS 13.4.1
    CPU: (10) arm64 Apple M2 Pro
    Memory: 12.78 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.1 - ~/Library/Caches/fnm_multishells/22781_1678232715369/bin/node
    npm: 9.5.1 - ~/Library/Caches/fnm_multishells/22781_1678232715369/bin/npm
    pnpm: 8.6.7 - ~/Library/Caches/fnm_multishells/22781_1678232715369/bin/pnpm
  Browsers:
    Chrome: 114.0.5735.198
    Safari: 16.5.1
  npmPackages:
    @vitest/coverage-v8: 0.33.0 => 0.33.0
    @vitest/ui: 0.33.0 => 0.33.0
    vite: 4.4.3 => 4.4.3
    vitest: 0.33.0 => 0.33.0

Used Package Manager

pnpm

Validations

@stackblitz
Copy link

stackblitz bot commented Jul 11, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@sheremet-va
Copy link
Member

I don't see how this is related to Vitest?

@jviall
Copy link
Author

jviall commented Jul 11, 2023

I don't see how this is related to Vitest?

what else would it be related to?

@sheremet-va
Copy link
Member

I don't see how this is related to Vitest?

what else would it be related to?

all functions are imported from vite, not vitest

@jviall
Copy link
Author

jviall commented Jul 12, 2023

Looks like there's an issue with an open PR to solve this with Vite: vitejs/vite#13792 (review)

@jviall jviall closed this as completed Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants