-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.34.0 "URL is not defined" failure when using isolate: false
#3984
Labels
Comments
I also see this error with Node 18.6.0, but upgrading to 18.17.1 fixes it. |
After some more testing, I still get this error on 18.17.1 some times. Seems pretty random from run to run if tests run ok or fail with this error. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
After upgrading from
vitest
version 0.33.0 to 0.34.0 I'm seeing this failure in any tests which rely on theURL
global:I'm guessing this is related to the change in:
What's interesting is that my failure only occurs when
isolate: false
is used. Settingisolate: true
makes the problem go away. The error also doesn't happen when focusing on specific tests in watch mode. It only shows up when running my entire test suite.Rolling back to 0.33.0 fixes the issue.
Reproduction
I haven't been able to reproduce via StackBlitz in a minimal scenario yet, so it's possible it's caused by some interplay between other tests, or perhaps the order in which tests run?
Any advice on what the issue might be? Maybe I can give it another try.
System Info
Used Package Manager
yarn
Validations
The text was updated successfully, but these errors were encountered: