inner suite { sequential: true } doesn't override outer suite { concurrent: true }

[hi-ogawa]

Describe the bug

I'm not sure what we want it to happen since users could technically also write completely conflicting things like { sequential: true, concurrent: true }. As shown in the reproduction below, describe.sequential and describe('...', { concurrent: false }) correctly resets, so I think we could also support { sequential: true } too at least?

describe('repro', { concurrent: true }, () => {
  // sequential
  describe.sequential("ok 1", () => { ... });

  // sequential
  describe("ok 2", { concurrent: false }, () => { ... });

  // this is still concurrent
  describe('bad', { sequential: true }, () => { ... });
});

I spotted this while writing test cases for #5491. Probably the condition around here is relevant:

vitest/packages/runner/src/suite.ts

Lines 289 to 291 in 7454aea

	// inherit concurrent / sequential from current suite
	options.concurrent = this.concurrent || (!this.sequential && options?.concurrent)
	options.sequential = this.sequential || (!this.concurrent && options?.sequential)

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-79s4mn?file=test%2Frepro.test.ts

System Info

(stackblitz)

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @vitest/ui: latest => 1.6.0 
    vite: latest => 5.2.11 
    vitest: latest => 1.6.0

Used Package Manager

npm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.