You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In particular, blue is hard to read on dark mode, and yellow is hard to read on light mode.
All colours used should be checked against an accessibility colour checker to ensure their contrast is high enough, and this likely means having a different colour set for light mode and dark mode, as it's hard to have a single colour which works for both and also looks good.
Here are some screenshots:
Reproduction
To reproduce, start with the Workspace vitest example: https://github.com/vitest-dev/vitest/tree/main/examples/workspace
Then rename one of the package folders to cli (this won't be the only way to force it to be blue, just one I know works)
Run UI tests and set your theme in vitest UI to dark mode
See result:
Describe the bug
When running vitest UI on a Vitest Workspace, some of the workspace names are in a colour that is very hard to look at / read.
I can see the colours are basically defined here:
vitest/packages/ui/client/utils/task.ts
Line 28 in 85fb94a
In particular, blue is hard to read on dark mode, and yellow is hard to read on light mode.
All colours used should be checked against an accessibility colour checker to ensure their contrast is high enough, and this likely means having a different colour set for light mode and dark mode, as it's hard to have a single colour which works for both and also looks good.
Here are some screenshots:
Reproduction
To reproduce, start with the Workspace vitest example:
https://github.com/vitest-dev/vitest/tree/main/examples/workspace
Then rename one of the package folders to
cli
(this won't be the only way to force it to be blue, just one I know works)Run UI tests and set your theme in vitest UI to dark mode
See result:
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: