Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping while a query is being executed #133

Open
silvanheller opened this issue May 10, 2022 · 1 comment
Open

Ping while a query is being executed #133

silvanheller opened this issue May 10, 2022 · 1 comment

Comments

@silvanheller
Copy link
Member

The Websocket Implementation of the ping command currently does not work while a query is being executed. This means users have the impression the Cineast instance is disconnected. This has two possible remedies: (i) investigate the cause of the WS issues or (ii) migrate the ping implementation to REST.

@lucaro
Copy link
Member

lucaro commented May 10, 2022

I'd vote for option (i) since otherwise, you won't have any information about the state of the websocket connection. If it isn't kept continuously open but rather established only when a query is sent, I would not see a reason for keeping the ping at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants