Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce logging of table transformers results #3291

Closed
ikalinin1 opened this issue Oct 21, 2022 · 2 comments
Closed

Introduce logging of table transformers results #3291

ikalinin1 opened this issue Oct 21, 2022 · 2 comments
Labels
feature New feature or request
Milestone

Comments

@ikalinin1
Copy link
Member

In order to provide user clear view of the table transformers resulting table we need to introduce logging mechanism

@ikalinin1 ikalinin1 added the feature New feature or request label Oct 21, 2022
@GrimA9e
Copy link
Contributor

GrimA9e commented Oct 26, 2022

In addition to logging I would suggest to unify transformers/tables/files definition order. Currently it is different, viz.:

Examples:
{transformer=FROM_DB, dbKey=testdb, sqlQuery=$\{sql-all-category-product-last-flag\}}
{transformer=FILTERING, byMaxRows=$\{filter-products\}}

and

Examples:
{transformer=FILTERING, column.category=.*lipstick.*}
/tables/vime/photo_p${index}.table

Initial source is on the opposite sides of the list

@valfirst
Copy link
Collaborator

valfirst commented Dec 5, 2022

Implemented in #3388

@valfirst valfirst closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants