Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Quotes #595

Closed
vkbo opened this issue Jan 23, 2021 · 2 comments · Fixed by #804
Closed

Block Quotes #595

vkbo opened this issue Jan 23, 2021 · 2 comments · Fixed by #804
Assignees
Labels
enhancement Request: New feature or improvement

Comments

@vkbo
Copy link
Owner

vkbo commented Jan 23, 2021

Add support for block quotes. The syntax would be as simple as starting a line with >, so it can use the same parsing logic as comments.

@vkbo vkbo added the enhancement Request: New feature or improvement label Jan 23, 2021
@vkbo vkbo self-assigned this Jan 23, 2021
@vkbo
Copy link
Owner Author

vkbo commented May 4, 2021

I'm still considering syntax for block formatting. The Tokenizer class, and the converter classes, can already handle block (paragraph) formats, so perhaps it is an idea to add a simple syntax for setting a format for a given block. For instance:

  • [L] for left aligned
  • [C] for centred
  • [R] for right aligned
  • [H] for highlighted
  • [Q] for block quote

Perhaps even more. The benefit is that the codes can be extended without the need to invent numerous new types of code.

The block should start or end with these characters to have its block format set, and the codes themselves could potentially be set to hidden so that they only exist in the actual file stored to disk, and are read into the block data of the QTextDocument when the document text is set.

Still have to think more about this, but doing this means the code is moving away from being plain text with markup as well.

@vkbo vkbo linked a pull request Jun 10, 2021 that will close this issue
3 tasks
@vkbo vkbo added this to the Release 1.4 Beta 1 milestone Jun 10, 2021
@vkbo
Copy link
Owner Author

vkbo commented Jun 10, 2021

This feature issue has been replaced with #803. Instead of block quotes, the syntax allows for indented blocks (or rather, blocks with a margin). This can be used for block quotes and uses the same syntax as proposed here.

@vkbo vkbo closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request: New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant