Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom themes #892

Closed
vkbo opened this issue Sep 12, 2021 · 7 comments · Fixed by #893 or #984
Closed

Custom themes #892

vkbo opened this issue Sep 12, 2021 · 7 comments · Fixed by #893 or #984
Assignees
Labels
enhancement Request: New feature or improvement user interface Component: General user interface

Comments

@vkbo
Copy link
Owner

vkbo commented Sep 12, 2021

It is possible to add themes at the moment, but they have to be made directly in the assets folder in the source code. Perhaps it is a good idea to allow themes to be added into a system data folder from within novelWriter.

A small dialog can take care of that part. But it may also be a good idea to add a theme editor.

@vkbo vkbo added the enhancement Request: New feature or improvement label Sep 12, 2021
@vkbo vkbo self-assigned this Sep 12, 2021
@vkbo vkbo added this to the Future Release milestone Sep 12, 2021
@Ellipsine
Copy link

I would agree for anything that facilitate customisation. I think customisation is important as we spend hours on a writing software.
Right now I copy my assets custom files and duplicate them in the asset folder as soon as I intall a new version of NW.

@vkbo
Copy link
Owner Author

vkbo commented Sep 12, 2021

I also accept new themes as contributions. I've already added the Solarized Light and Dark themes from another user.

@Ellipsine
Copy link

Understood ! I don't know if it fits to everyone taste but here my custom themes :

I would call it "warm grey" to keep eyes from the bright of white, from the dark theme which hurts astigmate eyes, or overly saturated colors of the solarize theme and cut a maximum of blue screen color.

@vkbo
Copy link
Owner Author

vkbo commented Sep 17, 2021

Thanks! I'll have a look at them. I'm currently rewriting the whole theme code, so I'll leave it until after.

From version 1.6 you should be able to add user themes. I think I will make a full GUI for it since it's just a series of colour settings.

@Ellipsine
Copy link

Thanks! I'll have a look at them. I'm currently rewriting the whole theme code, so I'll leave it until after.

From version 1.6 you should be able to add user themes. I think I will make a full GUI for it since it's just a series of colour settings.

Seems perfect to me, thank you a lot !

@vkbo vkbo linked a pull request Sep 19, 2021 that will close this issue
6 tasks
@vkbo vkbo added the user interface Component: General user interface label Dec 31, 2021
@vkbo
Copy link
Owner Author

vkbo commented Jan 4, 2022

The option to save user-defined themes in the local app data folder is added to 1.6 Beta 1. This means there is no need to add files to the assets folder in the source. The documentation needs to explain how to do it. I will finish this for the next Beta release of 1.6.

@vkbo vkbo linked a pull request Feb 6, 2022 that will close this issue
6 tasks
@vkbo
Copy link
Owner Author

vkbo commented Feb 6, 2022

PR #984 adds the needed information to the documentation. I'm closing this issue now. The idea of making a special tool for managing and editing themes has been split out into issue #985.

@vkbo vkbo closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request: New feature or improvement user interface Component: General user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants