Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeResource "missing context in handler" fixme #160

Closed
Florian-Schoenherr opened this issue Nov 5, 2020 · 7 comments
Closed

CodeResource "missing context in handler" fixme #160

Florian-Schoenherr opened this issue Nov 5, 2020 · 7 comments

Comments

@Florian-Schoenherr
Copy link
Contributor

Florian-Schoenherr commented Nov 5, 2020

Problem: We don't have context() anymore when using DynamicResourceHandler.
See: https://github.com/vlingo/vlingo-schemata/blob/a6e682f64e636214b3e1636318c5b047cf58b92e/src/main/java/io/vlingo/schemata/resource/CodeResource.java#L76
This is also marked with "FIXME", so maybe now is the time to fix it. As far as I know, context() shouldn't be used directly, right?
I also don't really know why we mock auth here.
Maybe this had to do with some already resolved stuff, let me know.

related: #55 #60

@Florian-Schoenherr
Copy link
Contributor Author

Florian-Schoenherr commented Nov 5, 2020

I got it to work by commenting out the context/collector parts of it.
I would like to know how this was meant to work, what this was meant to do.
@VaughnVernon you probably have a grasp on this, see related issue.

@VaughnVernon
Copy link
Contributor

I added support for Context. Please see this closed issue. You can manually activate it in schemata by passing a self reference when instantiating the ResourceBuilder. You may close this once you see it's working.

vlingo/xoom-turbo#4

@Florian-Schoenherr
Copy link
Contributor Author

recordDependency was never implemented, so I could add context back but it wouldn't do anything.
Should I just log the context/request to see if it works?

@VaughnVernon
Copy link
Contributor

Sure. Demonstrate that it could work if it is needed.

I haven't looked at the feature. Is it important to support this? Any idea why it isn't supported?

@Florian-Schoenherr
Copy link
Contributor Author

Florian-Schoenherr commented Nov 7, 2020

I don't know, maybe there were some more plans for schemata to have generated codes depend on each other?

There is no dependency resolver implementation; if one SchemaVersion has a dependency on another named SchemaVersion there is no way to resolve that dependency type. #55

No idea what this means.

Authorization would get validated afterwards in io.vlingo.schemata.query.CodeQueriesActor#validate. #55

That method doesn't exist anymore, maybe this is just old.

@VaughnVernon
Copy link
Contributor

@Florian-Schoenherr Please make the adjustments to the code so that it can access that Context and close this issue. Then create a new issue to figure out for what use this was intended. It may be that we decide to remove the code rather than allow it to push us to something we don't need, or worse yet, someone later assumes that it works and exposes it to the UI and CLI.

@Florian-Schoenherr
Copy link
Contributor Author

Fixed by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants