-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue Internet Explorer #292
Comments
Need to check.... |
I added some improvements to listeners in 2.6.2, @dgroh can you pls approve that it helped? (I don't have computer which is running IE). |
If you mean that |
it is... What version of IE are you using? Could please do some profiling to tell what function make it hangs? |
BTW, the demo is still with the scrolling listeners but I made it more efficient within the component. Can you tell if you see any difference within your application? |
@vlio20 , i'm using IE11. I'll compare the 2.6.1 and 2.6.2 within my application on Monday. Profiling on IE is hard, so I think the easiest first step for me will be to fork, remove the listener and see what happens. I'll let you know. |
Hi @vlio20 , good news, within the application it's much quickier now. The only problem is when the datepicker is opened. Before this update, the browser was hanging even when the datepicker was closed, now it hangs only when opened. Any chance to fix this also? For usability, I'm not quite sure if it makes sense to still show the datepicker when scrolling. See the datepicker from amterial design: https://material.angular.io/components/datepicker/examples You are not even able to scroll if it's opened. |
I don't want to do such ux decisions. You can block the scrolling on your side. I can't remove the scrolling listener when the picker is open when the element attached to body or other element that moakes the picker in absolute position. I saw that you forked the repo, let me know if you find any other options for improvement. |
We have a big problem with IE when embedding the DatePicker.
If we remove it everything work fine. We have four of them in our web site.
I could also reproduce it on your your web site: https://vlio20.github.io/angular-datepicker/
Try scrolling open and down several times. Also open the task manager and check that internet explorer is driving crazy.
Is there any event bound to it like onScroll or something like that?
Thank you very much
The text was updated successfully, but these errors were encountered: