Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align make manifest with controller-manager role #718

Open
kerthcet opened this issue Feb 20, 2025 · 1 comment
Open

Align make manifest with controller-manager role #718

kerthcet opened this issue Feb 20, 2025 · 1 comment
Labels
kind/misc priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kerthcet
Copy link
Collaborator

Once we run make manifest to generate the kustomized configurations, the controller manager role.yaml will be updated, some verbs will be removed. This is because it's not aligned with the kubebuilder Tag.

I have to add the roles manually to avoid removing some configurations by accident. We should make them aligned and always use make manifest to generate the configurations.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 25, 2025

We can come up a better way to do it. The last change is due to standalone component support so we change the folder structure a little bit. Do you think there's a better way? feel free to share your thoughts

@Jeffwan Jeffwan added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/misc labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants