[v0.9.1][DP] Tiny fix of dp and update example #1277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 tasks
|
Please help review this, thanks! @wangxiyuan |
wangxiyuan
approved these changes
Jun 19, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
29 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
|
@zzzzwwjj have a PR to remove |
Yes, I noticed that the mainly changes, including bug fix, example modification, are also included in #1422. Thus closing this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
backport form #1273
Add
max_num_tokens_across_dptoAscendMetadatato fix dpThis pr fixes the bug introduced by #1229, which add an arg
max_num_tokens_across_dpwhen dp_size > 1.Does this PR introduce any user-facing change?
How was this patch tested?