Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Apr 10, 2025

What this PR does / why we need it?

This is one step of CI for key features

  1. Add mutlimodal test
  2. Add Qwen2.5Vl_3B、 32B test
  3. Add DeepSeek-V2-Lite test

Does this PR introduce any user-facing change?

How was this patch tested?

@Potabk Potabk changed the title [4/N][CI/UT] Add Qwen2.5VL test [4/N][CI/UT] Add Qwen2.5VL-3B and Qwen2.5-7B test Apr 10, 2025
@MengqingCao MengqingCao self-assigned this Apr 10, 2025
@MengqingCao
Copy link
Collaborator

overall lgtm, thanks!

@Potabk
Copy link
Collaborator Author

Potabk commented Apr 10, 2025

overall lgtm, thanks!

Ok, and I'm downloading deepseek-v2-lite and qwen2.5vl-3b weight to the new storage, actions won't success until weights are ready

@Potabk Potabk force-pushed the ci branch 4 times, most recently from 5e76374 to dd0a228 Compare April 14, 2025 03:17
@Potabk
Copy link
Collaborator Author

Potabk commented Apr 14, 2025

skip qwen2.5_vl test on v1 until issue solved

@wangxiyuan
Copy link
Collaborator

Please add multicard test as well. such as qwen2.5 vl 32B

@Potabk Potabk force-pushed the ci branch 4 times, most recently from 59d86e2 to 16db37f Compare April 14, 2025 10:43
@Potabk Potabk changed the title [4/N][CI/UT] Add Qwen2.5VL-3B and Qwen2.5-7B test [4/N][CI/UT] Add Qwen2.5VL-3B test Apr 14, 2025
@Potabk Potabk force-pushed the ci branch 4 times, most recently from d77fa4f to bfdc845 Compare April 15, 2025 01:18
@Potabk Potabk changed the title [4/N][CI/UT] Add Qwen2.5VL-3B test [4/N][CI/UT] Add Qwen2.5VL test Apr 15, 2025
- name: Run vllm-project/vllm-ascend test on V0 engine
env:
VLLM_USE_V1: 0
VLLM_WORKER_MULTIPROC_METHOD: spawn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why V0 need this env?

Copy link
Collaborator Author

@Potabk Potabk Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test distribute with Qwen2.5-VL-32B on v0, encountering errors RuntimeError: Cannot re-initialize NPU in forked subprocess. To use NPU with multiprocessing, you must use the 'spawn' start method

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MengqingCao I don't think v0 need this change, please take a look. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think there are some multiprocessing problems on destributed inference tests. I think we can use spawn to avoid this issue, and I'm looking into this now, will fix it when finding a better resolution

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After debugging the distributed case, I found that the mainly re-initialize conflict is caused by the child process forked by the main process process0.

  1. For example, npu:1 will be initialized in child process process1, and this process will turn to sleeping status when tearing down the first ut.
  2. While the second distributed ut setting up, process2, a new child process, also try to initialize npu:1, then the re-initialize error is raised.
  3. Moreover, process1 cannot be killed clearly by hand. Thus I reconmend to use spawn here to solve this issue.

@Potabk plz add this analysis as comment in this pr, thx!

@Potabk Potabk changed the title [4/N][CI/UT] Add Qwen2.5VL test [4/N][CI/UT] Add Qwen2.5-VL and DeepSeek-V2-Lite test Apr 21, 2025
Potabk added 3 commits April 21, 2025 11:37
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
This was referenced Apr 24, 2025
wangxiyuan pushed a commit that referenced this pull request Apr 24, 2025
### What this PR does / why we need it?
Part of #499 
Add qwen2.5-vl test on single npu, v1 engine is excluded because
qwen2.5-vl has some problems with v1 now, at the same time, this test
can also make #639 more credible

Signed-off-by: wangli <wangli858794774@gmail.com>
ttanzhiqiang pushed a commit to ttanzhiqiang/vllm-ascend that referenced this pull request Apr 27, 2025
### What this PR does / why we need it?
Part of vllm-project#499 
Add qwen2.5-vl test on single npu, v1 engine is excluded because
qwen2.5-vl has some problems with v1 now, at the same time, this test
can also make vllm-project#639 more credible

Signed-off-by: wangli <wangli858794774@gmail.com>
wangxiyuan pushed a commit that referenced this pull request May 12, 2025
### What this PR does / why we need it?
Add deepseek-v2-lite test, part of #499 
---------

Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk
Copy link
Collaborator Author

Potabk commented May 12, 2025

Since all the sub pr has landed, we don't need this pr any more

@Potabk Potabk closed this May 12, 2025
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
### What this PR does / why we need it?
Add deepseek-v2-lite test, part of vllm-project#499 
---------

Signed-off-by: wangli <wangli858794774@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Part of vllm-project#499 
Add qwen2.5-vl test on single npu, v1 engine is excluded because
qwen2.5-vl has some problems with v1 now, at the same time, this test
can also make vllm-project#639 more credible

Signed-off-by: wangli <wangli858794774@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Add deepseek-v2-lite test, part of vllm-project#499 
---------

Signed-off-by: wangli <wangli858794774@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants