Skip to content

Commit 0825197

Browse files
authored
[Bugfix][ROCm][DeepSeek] Fix for forward_hip in rope for DeepSeek (#27373)
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
1 parent 9ef3d5b commit 0825197

File tree

1 file changed

+2
-5
lines changed
  • vllm/model_executor/layers/rotary_embedding

1 file changed

+2
-5
lines changed

vllm/model_executor/layers/rotary_embedding/base.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,8 @@ def forward_hip(
165165
self.rotary_dim,
166166
self.is_neox_style,
167167
)
168-
else:
169-
# ops.rotary_embedding() is an in-place operation
170-
# that updates the query and key tensors.
171-
self.forward_cuda(positions, query, key)
172-
return query, key
168+
return query, key
169+
return self.forward_cuda(positions, query, key)
173170

174171
def forward_xpu(
175172
self,

0 commit comments

Comments
 (0)