Skip to content

Commit fbb13a2

Browse files
Revert "[V1] [Bugfix] eagle bugfix and enable correct lm_head for multimodal (#18034)" (#18600)
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
1 parent a1fe24d commit fbb13a2

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

vllm/transformers_utils/configs/eagle.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ def __init__(self,
7070

7171
if self.model is not None:
7272
for k, v in self.model.to_dict().items():
73-
setattr(self, k, v)
73+
if not hasattr(self, k):
74+
setattr(self, k, v)
7475

7576
@classmethod
7677
def from_pretrained(

vllm/v1/spec_decode/eagle.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from vllm.forward_context import set_forward_context
1010
from vllm.logger import init_logger
1111
from vllm.model_executor.model_loader import get_model
12-
from vllm.model_executor.models import supports_multimodal
1312
from vllm.model_executor.models.llama_eagle3 import Eagle3LlamaForCausalLM
1413
from vllm.triton_utils import tl, triton
1514
from vllm.v1.attention.backends.flash_attn import FlashAttentionMetadata
@@ -311,10 +310,7 @@ def load_model(self, target_model: nn.Module) -> None:
311310
if self.vllm_config.speculative_config.method != "eagle3" and \
312311
hasattr(target_model, "lm_head"):
313312
logger.info("Loading EAGLE LM head weights from the target model.")
314-
if supports_multimodal(target_model):
315-
self.model.lm_head = target_model.get_language_model().lm_head
316-
else:
317-
self.model.lm_head = target_model.lm_head
313+
self.model.lm_head = target_model.lm_head
318314

319315
@torch.inference_mode()
320316
def dummy_run(

0 commit comments

Comments
 (0)