Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference server not working with models tuned on <|system|>,<|prompter|>,<|assistant|> or <|im_start|>,<|im_end|> format #1000

Closed
horiacristescu opened this issue Sep 9, 2023 · 5 comments

Comments

@horiacristescu
Copy link

horiacristescu commented Sep 9, 2023

Trying to run the vLLM server with https://huggingface.co/Open-Orca/LlongOrca-13B-16k but it returns just white space.

It uses messages formatted as:

<|im_start|>system
You are LlongOrca, a large language model trained by Alignment Lab AI. Write out your reasoning step-by-step to be sure you get the right answers!
<|im_end|>

Also tried https://huggingface.co/OpenAssistant/llama2-13b-orca-8k-3319 but it returns empty.
Message format:

<|system|>system message</s><|prompter|>user prompt</s><|assistant|>

Is it possible to use models that require such different formatting? The vLLM request is abstracted away and only sends messages list. I tried wrapping the content with the special tokens.

The only prompt format that works for me on vLLM server is

### Instruction:
<prompt>
### Response:

from Open-Orca/OpenOrca-Platypus2-13B

Maybe I am missing an argument when running the server?

@horiacristescu horiacristescu changed the title Inference server not working with models tuned on <|system|> <|prompter|> <|assistant|> format Inference server not working with models tuned on <|system|>,<|prompter|>,<|assistant|> or <|im_start|>,<|im_end|> format Sep 9, 2023
@horiacristescu
Copy link
Author

horiacristescu commented Sep 9, 2023

On further investigation it seems related to the get_conversation_template() function.
It returns the wrong template for the model (Open-Orca/LlongOrca-13B-16k, should be with <|im_start|> and <|im_end|>)

conv= {'name': 'one_shot', 'system_template': '{system_message}', 'system_message': "A chat between a curious human and an artificial intelligence assistant. The assistant gives helpful, detailed, and polite answers to the human's questions.", 'roles': ('Human', 'Assistant'), 'messages': [['Human', 'Got any creative ideas for a 10 year old’s birthday?'], ['Assistant', "Of course! Here are some creative ideas for a 10-year-old's birthday party:\n1. Treasure Hunt: Organize a treasure hunt in your backyard or nearby park. Create clues and riddles for the kids to solve, leading them to hidden treasures and surprises.\n2. Science Party: Plan a science-themed party where kids can engage in fun and interactive experiments. You can set up different stations with activities like making slime, erupting volcanoes, or creating simple chemical reactions.\n3. Outdoor Movie Night: Set up a backyard movie night with a projector and a large screen or white sheet. Create a cozy seating area with blankets and pillows, and serve popcorn and snacks while the kids enjoy a favorite movie under the stars.\n4. DIY Crafts Party: Arrange a craft party where kids can unleash their creativity. Provide a variety of craft supplies like beads, paints, and fabrics, and let them create their own unique masterpieces to take home as party favors.\n5. Sports Olympics: Host a mini Olympics event with various sports and games. Set up different stations for activities like sack races, relay races, basketball shooting, and obstacle courses. Give out medals or certificates to the participants.\n6. Cooking Party: Have a cooking-themed party where the kids can prepare their own mini pizzas, cupcakes, or cookies. Provide toppings, frosting, and decorating supplies, and let them get hands-on in the kitchen.\n7. Superhero Training Camp: Create a superhero-themed party where the kids can engage in fun training activities. Set up an obstacle course, have them design their own superhero capes or masks, and organize superhero-themed games and challenges.\n8. Outdoor Adventure: Plan an outdoor adventure party at a local park or nature reserve. Arrange activities like hiking, nature scavenger hunts, or a picnic with games. Encourage exploration and appreciation for the outdoors.\nRemember to tailor the activities to the birthday child's interests and preferences. Have a great celebration!"]], 'offset': 2, 'sep_style': <SeparatorStyle.ADD_COLON_SINGLE: 1>, 'sep': '\n### ', 'sep2': None, 'stop_str': '###', 'stop_token_ids': None}

These definitions come from FastChat
https://github.com/lm-sys/FastChat/blob/main/fastchat/conversation.py

Maybe I only need to tell vLLM to use a different conversation template

@viktor-ferenczi
Copy link
Contributor

The get_conversation_template function comes from FastChat. So this issue may belong there.

@agrogov
Copy link

agrogov commented Oct 4, 2023

When inferencing mistralai/Mistral-7B-Instruct-v0.1 or mistralai/Mistral-7B-v0.1 models vLLM using this template instead of this one

@timothylimyl
Copy link

how do we go about changing the system prompt?

@vackosar
Copy link

@horiacristescu I have similar problem. Can you try setting --served-model-name zephyr and then requesting the model under zephyr name. That will actually cause retrieval of the right conversation format. But still, it is returning ChatML special tokens and just generating the conversation on-and-on for me. I still had to add stopping sequences for the special tokens. vLLM it seems to be lacking the stopping on special tokens.

@hmellor hmellor closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@horiacristescu @viktor-ferenczi @agrogov @vackosar @hmellor @timothylimyl and others