Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: How to run speculative models with tensor parallelism? #10562

Open
1 task done
cxxuser opened this issue Nov 22, 2024 · 2 comments
Open
1 task done

[Feature]: How to run speculative models with tensor parallelism? #10562

cxxuser opened this issue Nov 22, 2024 · 2 comments

Comments

@cxxuser
Copy link

cxxuser commented Nov 22, 2024

🚀 The feature, motivation and pitch

I noticed that the current speculative mode does not support tp from this link (https://docs.vllm.ai/en/stable/models/spec_decode.html).

However, not supporting TP will greatly limit the choice of speculative models. I would like to know why there is no TP support for speculative models. I am trying to read and modify this part of the code, but I don't understand why the scorer model can support TP, but the speculative model cannot. What are the considerations in system design?

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@ShangmingCai
Copy link
Contributor

ShangmingCai commented Nov 22, 2024

This issue is related to the following issue and pull.
#5814
#5414

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants