Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Bug]: Consider sampler in memory profiling #13507

Closed
1 task done
WoosukKwon opened this issue Feb 19, 2025 · 0 comments · Fixed by #13594
Closed
1 task done

[V1][Bug]: Consider sampler in memory profiling #13507

WoosukKwon opened this issue Feb 19, 2025 · 0 comments · Fixed by #13594
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@WoosukKwon
Copy link
Collaborator

Your current environment

The output of `python collect_env.py`
Your output of `python collect_env.py` here

🐛 Describe the bug

Currently, V1 model runner does not consider (or run) sampler during the initial memory profiling. This should be fixed 1) for more accurate memory profiling and 2) to warm up the sampler before processing any real requests.

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant