Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequences in a batch have different physical blocks when they have common prefix. #680

Closed
YijiaZhao opened this issue Aug 6, 2023 · 0 comments

Comments

@YijiaZhao
Copy link

YijiaZhao commented Aug 6, 2023

When I use Baichuan, I found that every Sequence has its own physical block even the input data has common prefix(The length of the prefix is 16 which is equal to the block_size). Is it expected? According to
image
, I think they will use shared physical block.

This is my "block_tables", every sequence has a common prefix but different physical block id
(Pdb) seq_group_metadata_list[0].block_tables {0: [7303, 7302]}

(Pdb) seq_group_metadata_list[1].block_tables {1: [7301, 7300]}

(Pdb) seq_group_metadata_list[2].block_tables {2: [7299, 7298]}

(Pdb) seq_group_metadata_list[3].block_tables {3: [7297, 7296]}

(Pdb) seq_group_metadata_list[4].block_tables {4: [7295, 7294]}

@YijiaZhao YijiaZhao changed the title Every Sequence has its own physical block when they have common prefix. Every Sequence has different physical block when they have common prefix. Aug 6, 2023
@YijiaZhao YijiaZhao changed the title Every Sequence has different physical block when they have common prefix. Sequences in a batch have different physical blocks when they have common prefix. Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant