Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Model]: NVLM 1.0 #9040

Closed
1 task done
shermansiu opened this issue Oct 3, 2024 · 1 comment · Fixed by #9045
Closed
1 task done

[New Model]: NVLM 1.0 #9040

shermansiu opened this issue Oct 3, 2024 · 1 comment · Fixed by #9045
Labels
new model Requests to new models

Comments

@shermansiu
Copy link

The model to consider.

Collection: https://huggingface.co/collections/nvidia/nvlm-10-66e9f407c764a0ee6e37b7f4
NVLM-D 1.0 72B: https://huggingface.co/nvidia/NVLM-D-72B

The closest model vllm already supports.

https://github.com/vllm-project/vllm/blob/main/vllm/model_executor/models/internvl.py

The Huggingface inference code was reportedly adapted from the InternVL codebase.

Screenshot from 2024-10-03 07-17-00

What's your difficulty of supporting the model you want?

NVLM 1.0 has a new architecture that may take some time to support in vLLM.

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@shermansiu shermansiu added the new model Requests to new models label Oct 3, 2024
@nskumz
Copy link

nskumz commented Oct 3, 2024

yup, please make the model supports to vLLM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new model Requests to new models
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant